Help to debug...

[Berns]

Can anyone tell me why this script isn't working, I'm pretty sure that the problem is here (in the body):

<a href=&quot;

https://test01?source=

+ strSvr +&quot;><b>text text</b></a>

the entire script:


<script>
function getNvp(strKey) {
strVal = window.location.search.substr(1);
if(strVal.indexOf(strKey) >= 0)
{
strVal = strVal.substr(strVal.indexOf(strKey) + strKey.length);
// Check for & or +
if(strVal.indexOf(&quot;&&quot >= 0)
{
strVal = strVal.substr(0, strVal.indexOf(&quot;&&quot);
}
else if(strVal.indexOf(&quot;+&quot >= 0)
{
strVal = strVal.substr(0, strVal.indexOf(&quot;+&quot);
}
}
else
{
strVal = &quot;&quot;;
}

return strVal;
}

// Get the server name
strSvr = getNvp(&quot;source=&quot;

strUrl = &quot;<a href=

http://test.com?source=&quot;

+ strSvr+&quot;><font
color=#cc0000><b>pre-application approval</b></font></a>&quot;;
document.write (strUrl)
</script>


in the body (I'm pretty sure that this is where the problem is:

<a href=&quot;

https://test01?source=

+ strSvr +&quot;><b>text text</b></a>


All help is appreciated, thank in advance!

 

[tviman]

give this a shot...

strUrl = '<a href=&quot;

http://test.com?source=&quot;'

+ strSvr + '><font color=#cc0000><b>pre-application approval</b></font></a>';

note the single quotes as well as the embedded double quotes. Works kinda like paranthesis - you have to match pairs and placement. If you had opened a javascript console after you tried to open your page, you would have seen the error! There's always a better way...

 

[Berns]

This still isn't working right, Is the <a href> tag in the body correct?
Here is what I have:

<a href=&quot;

https://tester.test.com/testPubView01?source=+strSvr+&quot;>

 

[onpnt]

this is prbably the sloppiest thing I've ever written in javascript but it will work
replace
<a href=&quot;

https://tester.test.com/testPubView01?source=+strSvr+&quot;>

with this
<script>{document.write(&quot;<a href=&quot;+&quot;

https://tester.test.com/testPubView01?source=&quot;+strSvr+&quot;>&quot;);}</script>

you were correct that the syntax for the link was very wrong. you can't jsut concatinate a variable into a string without being in the <script> tags
I dare to learn more

http://www.onpntwebdesigns.com

admin@onpntwebdesigns.com

 

[onpnt]

BTW
take out the ; at the end of the links. These are placed there by TT
so the corrected should look like this

<script>{document.write(&quot;<a href=&quot;+&quot;[URL unfurl="true"]https://tester.test.com/testPubView01?source=&quot;+strSvr+&quot;>&quot;);}</script>[/URL]

I dare to learn more

http://www.onpntwebdesigns.com

admin@onpntwebdesigns.com