Form validation doesn't work with new script - why?

Julianne · May 18, 2003

I'm a newbie to ASP, so I've used a pre-made script to create a contact page that not only sends an e-mail via CDONTS but also writes the entries to a database.

In the past I've used the Check Form Dreamweaver extension (by Jaro von Flocken) to validate the text boxes, check box etc but this doesn't seem to work with this particular script (it has done with other ASP pages).

I don't get any error messages, but the form is still submitted even when fields are empty, which is what I don't want. I wonder if the Javascript is getting "taken over" by this line:

<%
if request.form("Submit&quot

<> "Submit" then
%>

What does this line actually do? Can I take it out or replace it with something else?! The next line is just <form action="contact.asp" method="POST">. Please let me know if you need me to post the page's code (it's quite long).

Many thanks.

Visit my ice hockey site at:

http://www.leevalleylions.co.uk

GaryC123 · May 18, 2003

Without seeing code its hard to say anything, it looks like its submitting to itself and if it hasn't been posted to itself then display stuff to get details etc else send email. Post some of your code. Are you getting a javascript error on the page when its loaded?

http://www.intouch-media.co.uk

Julianne · May 18, 2003

OK, here's the whole code. The Javascript is what's generated by the Check Form Dreamweaver extension (which has worked well for me on pages with other ASP scripts). It adds an onSubmit to the <form> tag, but it's preceded by the ASP if request.form("Submit&quot

... line.

<html>
<head>
<title>Add your site to our database</title>
<link href="test.css" rel="stylesheet" type="text/css">
<script language="JavaScript" type="text/JavaScript">
<!--
function MM_findObj(n, d) { //v4.01
var p,i,x; if(!d) d=document; if((p=n.indexOf("?&quot

)>0&&parent.frames.length) {
d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++) x=d.forms[n];
for(i=0;!x&&d.layers&&i<d.layers.length;i++) x=MM_findObj(n,d.layers.document);
if(!x && d.getElementById) x=d.getElementById; return x;
}

function YY_checkform() { //v4.66
//copyright (c)1998,2002 Yaromat.com
var args = YY_checkform.arguments; var myDot=true; var myV=''; var myErr='';var addErr=false;var myReq;
for (var i=1; i<args.length;i=i+4){
if (args[i+1].charAt(0)=='#'){myReq=true; args[i+1]=args[i+1].substring(1);}else{myReq=false}
var myObj = MM_findObj(args.replace(/\[\d+\]/ig,"&quot);
myV=myObj.value;
if (myObj.type=='text'||myObj.type=='password'||myObj.type=='hidden'){
if (myReq&&myObj.value.length==0){addErr=true}
if ((myV.length>0)&&(args[i+2]==1)){ //fromto
var myMa=args[i+1].split('_');if(isNaN(myV)||myV<myMa[0]/1||myV > myMa[1]/1){addErr=true}
} else if ((myV.length>0)&&(args[i+2]==2)){
var rx=new RegExp("^[\\w\.=-]+@[\\w\\.-]+\\.[a-z]{2,4}$"if(!rx.test(myV))addErr=true;
} else if ((myV.length>0)&&(args[i+2]==3)){ // date
var myMa=args[i+1].split("#" var myAt=myV.match(myMa[0]);
if(myAt){
var myD=(myAt[myMa[1]])?myAt[myMa[1]]:1; var myM=myAt[myMa[2]]-1; var myY=myAt[myMa[3]];
var myDate=new Date(myY,myM,myD);
if(myDate.getFullYear()!=myY||myDate.getDate()!=myD||myDate.getMonth()!=myM){addErr=true};
}else{addErr=true}
} else if ((myV.length>0)&&(args[i+2]==4)){ // time
var myMa=args[i+1].split("#" var myAt=myV.match(myMa[0]);if(!myAt){addErr=true}
} else if (myV.length>0&&args[i+2]==5){ // check this 2
var myObj1 = MM_findObj(args[i+1].replace(/\[\d+\]/ig,"&quot);
if(myObj1.length)myObj1=myObj1[args[i+1].replace(/(.*\[)|(\].*)/ig,"&quot];
if(!myObj1.checked){addErr=true}
} else if (myV.length>0&&args[i+2]==6){ // the same
var myObj1 = MM_findObj(args[i+1]);
if(myV!=myObj1.value){addErr=true}
}
} else
if (!myObj.type&&myObj.length>0&&myObj[0].type=='radio'){
var myTest = args.match(/(.*)\[(\d+)\].*/i);
var myObj1=(myObj.length>1)?myObj[myTest[2]]:myObj;
if (args[i+2]==1&&myObj1&&myObj1.checked&&MM_findObj(args[i+1]).value.length/1==0){addErr=true}
if (args[i+2]==2){
var myDot=false;
for(var j=0;j<myObj.length;j++){myDot=myDot||myObj[j].checked}
if(!myDot){myErr+='* ' +args[i+3]+'\n'}
}
} else if (myObj.type=='checkbox'){
if(args[i+2]==1&&myObj.checked==false){addErr=true}
if(args[i+2]==2&&myObj.checked&&MM_findObj(args[i+1]).value.length/1==0){addErr=true}
} else if (myObj.type=='select-one'||myObj.type=='select-multiple'){
if(args[i+2]==1&&myObj.selectedIndex/1==0){addErr=true}
}else if (myObj.type=='textarea'){
if(myV.length<args[i+1]){addErr=true}
}
if (addErr){myErr+='* '+args[i+3]+'\n'; addErr=false}
}
if (myErr!=''){alert('The required information is incomplete or contains errors:\t\t\t\t\t\n\n'+myErr)}
document.MM_returnValue = (myErr=='');
}
//-->
</script>
</head>
<body>


<%
if request.form("Submit&quot<> "Submit" then
%>
<form action="submitsite.asp" method="POST" name="sitesubmissions" onSubmit="YY_checkform('sitesubmissions','disclaimer','#q','1','Please tick the disclaimer box','EMail','S','2','Please enter your e-mail address','SiteTitle','#q','0','Please enter site title','URL','#q','0','Please enter URL');return document.MM_returnValue"">
<table cellpadding="0" cellspacing="0">
<tr>
<td valign="top">Your Name<br>
<input name="Name" type="text" id="Name" tabindex="1">
</td>
</tr>
<tr>
<td valign="top">E-Mail Address<br>
<input name="EMail" type="text" id="EMail" tabindex="2">
</td>
</tr>
<tr>
<td valign="top">The Name/Title of Your Website<br>
<input name="SiteTitle" type="text" id="SiteTitle" tabindex="3">
</td>
</tr>
<tr>
<td valign="top">Full URL (inc
http://)<br>
<input name="URL" type="text" id="URL" tabindex="4">
</td>
</tr>
<tr>
<td valign="top">What is your site about?<br>
<textarea name="Aims" rows="5" cols="42" tabindex="5"></textarea>
</td>
</tr>
<tr>
<td valign="top">What software did you use to develop your site?<br>
<textarea rows="5" name="Software" id="Software" cols="42" tabindex="6"></textarea>
</td>
</tr>
<tr>
<td valign="top">Please provide any other information that you feel may
be relevant:<br>
<textarea rows="5" name="Info" id="Info" cols="42" tabindex="7"></textarea>
</td>
</tr>
<tr>
<td><p>
<input name="disclaimer" type="checkbox" id="disclaimer" value="checkbox" />
I have read and understand the terms and conditions.</p>
</td>
</tr>
<tr>
<td><input name="Submit" type=submit value="Submit">
 <input name="reset" type=reset value="Reset">
</td>
</tr>
</table>
</form>
<%
else

strName=Request.form("Name&quot
strEMail=Request.form("EMail&quot
strSiteTitle=Request.form("SiteTitle&quot
strURL=Request.form("URL&quot
strAims=Request.form("Aims&quot
strSoftware=Request.form("Software&quot
strInfo=Request.form("Info&quot
strDate=Date

Set objConn = Server.CreateObject("ADODB.Connection&quot
ConnectionString="DRIVER={Microsoft Access Driver (*.mdb)}; DBQ=" & Server.MapPath("sitesubmissions.mdb&quot
objConn.Open ConnectionString

sqlQuery = "SELECT * FROM sitesubmissions"
Set objRS = Server.CreateObject("ADODB.Recordset&quot
objRS.Open sqlQuery, objConn, 1, 2

objRS.AddNew
objRS("Name&quot=strName
objRS("EMail&quot=strEMail
objRS("SiteTitle&quot=strSiteTitle
objRS("URL&quot=strURL
objRS("Aims&quot=strAims
objRS("Software&quot=strSoftware
objRS("Info&quot=strInfo
objRS("Date&quot=strDate

objRS.Update
objRS.Close
Set objRS = Nothing

strBody=strBody & "Thanks for submitting your site. Below is a copy of the details you submitted:" & chr(10) & chr(13)
strBody=strBody & "Name: " & strName & chr(10) & chr(13)
strBody=strBody & "EMail: " & strEMail & chr(10) & chr(13)
strBody=strBody & "Site Title: " & strSiteTitle & chr(10) & chr(13)
strBody=strBody & "URL: " & strURL & chr(10) & chr(13)
strBody=strBody & "Aims and Functions: " & strAims & chr(10) & chr(13)
strBody=strBody & "Software Used: " & strSoftware & chr(10) & chr(13)
strBody=strBody & "Further Information: " & strInfo & chr(10) & chr(13)
strBody=strBody & "Date: " & strDate & chr(10) & chr(13)
strBody=strBody & "--------------- " & chr(10) & chr(13)

Dim objCDO

Set objCDO = Server.CreateObject("CDONTS.NewMail&quot

objCDO.From = "test@testsite.com"
objCDO.To = "test@testsite.com"
objCDO.Subject = "Site Submitted"
objCDO.Body = strBody
objCDO.BodyFormat = 1
objCDO.MailFormat = 1
objCDO.Send

Set objCDO = Server.CreateObject("CDONTS.NewMail&quot

objCDO.From = "test@testsite.com"
objCDO.To = stremail
objCDO.Subject = "Site Submitted"
objCDO.Body = strBody
objCDO.BodyFormat = 1
objCDO.MailFormat = 1
objCDO.Send

Response.Write strName
Response.Write ", we have received details that you sent about:<BR><BR>"
Response.Write strSiteTitle
Response.Write ", which is located at " & strURL
Response.Write ".<BR><BR>"
Response.Write "Click any of the links to continue browsing."

end if
%>

</body>
</html>

Visit my ice hockey site at:
http://www.leevalleylions.co.uk

GaryC123 · May 18, 2003

You have an extra " at the end of this line, whether that is the problem?? but its nothing to do with your line

if request.form("Submit&quot

<> "Submit" then

that I can see

http://www.intouch-media.co.uk

GaryC123 · May 18, 2003

There is a problem on line 18

var myObj = MM_findObj(args.replace(/\[\d+\]/ig,"&quot

);

Error: args.replace is not a function
Source File:

http://localhost/test44.asp

Line: 18

You may be best posting this in the javascript forum

http://www.intouch-media.co.uk

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Form validation doesn't work with new script - why?

Julianne

Technical User

GaryC123

Programmer

Julianne

Technical User

GaryC123

Programmer

GaryC123

Programmer

Similar threads

Part and Inventory Search

Sponsor