dynamic sql in a stored procedure using group by

[drallabs]

can anyone tell me why the following stored procedure errors out?

Create Procedure StandEdit_ErrorCheck
@TableName VarChar(100)
AS

Declare @SQL VarChar(1000)

--Check for Duplicate Standids
SELECT @SQL = 'SELECT standid FROM '
SELECT @SQL = @SQL + @TableName + 'GROUP BY standid '
--GROUP BY standid
--HAVING count(*) > 1

Exec ( @SQL)

GO

StandEdit_ErrorCheck klstandedits

Server: Msg 156, Level 15, State 1, Line 1
Incorrect syntax near the keyword 'BY'.

 

[gmmastros]

Add a space between the apostrophe and Group.

-George

Strong and bitter words indicate a weak cause. - Fortune cookie wisdom

 

[drallabs]

thanks got that one.

 

[gmmastros]

Still getting errors?

To be a little 'safer' with regards to tables that may contain spaces in the name, you should add the square brackets around the table name, like this...

Create Procedure StandEdit_ErrorCheck
    @TableName VarChar(100)
AS

Declare @SQL VarChar(1000)

--Check for Duplicate Standids
SELECT @SQL = 'SELECT standid FROM '
SELECT @SQL = @SQL [!]+ '[' [/!]+ @TableName + '[!]] [/!]GROUP BY standid '
--GROUP BY standid
--HAVING count(*) > 1

Exec ( @SQL)

GO

-George

Strong and bitter words indicate a weak cause. - Fortune cookie wisdom