counting recurring items in a DB

[ibjdt]

i have a flat file with this configuration
customerID::itemCode::month.yr::#ofSearches

the #ofSearches is a running total for each itemCode - by customerID - in the correpsonding month.yr

in an admin script i try to extract each itemCode with the total #ofSearches in the current month (for all customers -- in later admin screens i break it down specifically by customer)

but i get the error
Modification of a read-only value

related to the way i try to add the #ofSearches:

open (BPNSEARCH, "data/Bpnsearch.txt");
@bpnsearch = <BPNSEARCH>;
close (BPNSEARCH);
foreach $bpnsearch (@bpnsearch)
{
 	chomp ($bpnsearch);
	@bpnsearch2=split(/::/,$bpnsearch);

######THIS IS WHERE I GET THE ERROR
#CREATE VAR OF EACH ITEMCODE AND INCREMENT BY #OF SEARCHES
	${$bpnsearch2[1]} += $bpnsearch2[3];
#####

foreach $bpnsearch (@bpnsearch)
{
 	chomp ($bpnsearch);
	@bpnsearch2=split(/::/,$bpnsearch);
#STORE EACH INCREMENT FROM ABOVE IN TEMP FILE FOR USE LATER
	unless($i{$bpnsearch2[1]}++)
	{
		push(@Tbpnsearch, "${$bpnsearch2[1]}\::$bpnsearch2[1]\n");
	}
}

any suggestions are greatly appreciated.

thanks.

 

[prex1]

Instead of trying to create a var, create a hash [tt]$itemcode{$bpnsearch2[1]} += $bpnsearch2[3];[/tt]
The second loop (BTW the first one is unterminated) is obscure to me (and why redo the splits?): try to rewrite it using the hash as above in a way that does what you want and come back if you still have problems.


Franco

http://www.xcalcs.com

: Online engineering calculations

http://www.megamag.it

: Magnetic brakes for fun rides

http://www.levitans.com

: Air bearing pads

 

[travs69]

${$bpnsearch2[1]} += $bpnsearch2[3];

probably needs to be

$myhash{$bpnsearch2[1]} += $bpnsearch2[3];

Then modify the rest of the code to match.


~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Travis - Those who say it cannot be done are usually interrupted by someone else doing it; Give the wrong symptoms, get the wrong solutions;

 

[travs69]

yeah.. what prex said

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Travis - Those who say it cannot be done are usually interrupted by someone else doing it; Give the wrong symptoms, get the wrong solutions;

 

[PinkeyNBrain]

Put some print statements in. My guess is that your var: $bpnsearch2[1] is evaluating to something like ARG. This would cause

${$bpnsearch2[1]} += $bpnsearch2[3];
# to evaluate as
$ARG += $bpnsearch2[3];

In general the above code would be risky. If you had no control over the values in $bpnsearch2[1], it could potentially evaluate into any variable you're using. Try using a %hash_var. eg:

READ_LOOP: {
   $itemCode{$bpnsearch2[1]} += $bpnsearch2[3];
}
REVIEW_LOOP:
{
   foreach $key (sort keys %itemCode) {
      print "key>$key<  val>$itemCode{$key}<\n";
   }
}

This will make $bpnsearch2[1] references into a hash versus defining them as variables on the fly.

 

[PinkeyNBrain]

yea ... what travs69 said what prex said.