convert to cfscript (example, help) 1

[imstillatwork]

I want to run this peice of code as cfscript:

<cfif IsDefined('attributes.paramlist')>
<cfloop index=&quot;i&quot; list=&quot;#attributes.paramlist#&quot;>
<cfif IsDefined('attributes.#i#')>
<cfset paramlist = Insert(paramlist,&quot;&amp;#i#=#evaluate('URLEncodedFormat(attributes.#i#)')#&quot;,0)>
</cfif>
</cfloop>
</cfif>

Its the last peice in the templete that is NOT cfscript, and i want ti to be, cant figure it out though. especialy this part:<cfif IsDefined('attributes.#i#')>

Also, is there another more efficient way to do this? It is in a custom tag.

Thanks!

 

[csteinhilber]

Looks fairly straightforward to convert, actually:

  if (IsDefined("attributes.paramlist")){
      for (i = 1; i LTE ListLen("#attributes.paramlist#"); i = i + 1){
         sListItem = ListGetAt("#attributes.paramlist#", i); 
         if (IsDefined("attributes.#sListItem#")){
                lstParamlist = Insert(lstParamlist,"&#sListItem#=#URLEncodedFormat(attributes[sListItem])#",0);
         }
      }
  }

would be more or less the direct translation.

Since attributes is a structure (when within a custom tag), you can access the value of the element by referencing the keyname... this means you don't have to use Evaluate (which is very slow).


But, since attributes is a structure, you can also dynamically determine the elements (by using StructKeyList)... rather than have to pass in the paramlist as an attribute. This elliminates the need for all the IsDefined as well... since the loop will only iterate over elements that exist:

  lstQueryString = "";
  if (NOT StructIsEmpty(attributes)){
      for (i IN attributes){
         lstQueryString = ListAppend("#lstQueryString#","#i#=#URLEncodedFormat(attributes[i])#","&");
      }
  }
  WriteOutput(link is: "somepage.cfm?#lstQueryString#");

As for whether it belongs in a custom tag or not... it's hard to say without knowing how you're actually using it. If you're running CF 5.0, you could certainly put it in a User Defined Function... but then the attributes structure wouldn't be available, so you'd have to figure out some way to solve that (probably use the &quot;arguments&quot; array instead).

A custom tag will probably be a bit slower than a UDF, or coding it directly in the page... but it's probably just fine as a tag.


-Carl

 

[imstillatwork]

great suggestions. thanks!

 

[imstillatwork]

it was easy to move to cfscript. I found my error. I will definatly work with what you sugestted also. i always try not to use evaluate. this was an old bit of code where i thought i needed to. change is good!

thansk again.

 

[imstillatwork]

actually, I'm going to leave the paramlist alone, I only want parameters on the list passed form page to page, not all of the other vars in attributes need to be thrown around.

definatly going to get rid of the evaluates though.