Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

  • Congratulations derfloh on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!

Can you look at my code and the error... I need you guys : (

Status
Not open for further replies.

ironyx

Technical User
Joined
Nov 13, 2001
Messages
134
Location
US
<%
var rsPersLoc = Server.CreateObject(&quot;ADODB.Recordset&quot;);
rsPersLoc.ActiveConnection = MM_JSIPS_STRING;
rsPersLoc.Source = &quot;SELECT DISTINCT tblPers.PersID, tblPers.LName, tblPers.FName, tblPers.MI, tblPers.Title, tblPers.PhoneDSN, tblPers.PhoneComm, tblPers.PhoneExt, tblPers.Email, tblPersLoc.LocationID, tblPersLoc.PersID, tblPersLoc.LocRole, tblPersLoc.RoleDate, tblLoc.LocationID, tblLoc.Loc_Code, tblLoc.Name, tblLoc.Location FROM tblPers LEFT OUTER JOIN (tblLoc RIGHT JOIN tblPersLoc ON tblLoc.LocationID = tblPersLoc.LocationID) ON tblPers.PersID = tblPersLoc.PersID&quot;;
rsPersLoc.CursorType = 0;
rsPersLoc.CursorLocation = 2;
rsPersLoc.LockType = 3;
rsPersLoc.Open();
var rsPersLoc_numRows = 0;
%>
<%
var Recordset1__MM_ColParam = &quot;1&quot;;
if(String(Request.QueryString(&quot;PersID&quot;)) != &quot;undefined&quot;) {
Recordset1__MM_ColParam = String(Request.QueryString(&quot;PersID&quot;));
}
%>
<%
var Recordset1 = Server.CreateObject(&quot;ADODB.Recordset&quot;);
Recordset1.ActiveConnection = MM_JSIPS_STRING;
Recordset1.Source = &quot;SELECT DISTINCT tblPers.PersID, tblPers.LName, tblPers.FName, tblPers.MI, tblPers.Title, tblPers.PhoneDSN, tblPers.PhoneComm, tblPers.PhoneExt, tblPers.Email, tblPersLoc.LocationID, tblPersLoc.PersID, tblPersLoc.LocRole, tblPersLoc.RoleDate, tblLoc.LocationID, tblLoc.Loc_Code, tblLoc.Name, tblLoc.Location FROM tblPers LEFT OUTER JOIN (tblLoc RIGHT JOIN tblPersLoc ON tblLoc.LocationID = tblPersLoc.LocationID) ON tblPers.PersID = tblPersLoc.PersID WHERE tblPersLoc.PersID = &quot;+ Recordset1__MM_ColParam.replace(/'/g, &quot;''&quot;) + &quot;&quot;;
Recordset1.CursorType = 0;
Recordset1.CursorLocation = 2;
Recordset1.LockType = 3;
Recordset1.Open();
var Recordset1_numRows = 0;
%>
<%
var Repeat1__numRows = 10;
var Repeat1__index = 0;
rsPersonnel_numRows += Repeat1__numRows;
%>
<%
var Repeat1__numRows = 10;
var Repeat1__index = 0;
rsPersLoc_numRows += Repeat1__numRows;
%>
<%
// *** Recordset Stats, Move To Record, and Go To Record: declare stats variables

// set the record count
var rsPersonnel_total = rsPersonnel.RecordCount;

// set the number of rows displayed on this page
if (rsPersonnel_numRows < 0) { // if repeat region set to all records
rsPersonnel_numRows = rsPersonnel_total;
} else if (rsPersonnel_numRows == 0) { // if no repeat regions
rsPersonnel_numRows = 1;
}

// set the first and last displayed record
var rsPersonnel_first = 1;
var rsPersonnel_last = rsPersonnel_first + rsPersonnel_numRows - 1;

// if we have the correct record count, check the other stats
if (rsPersonnel_total != -1) {
rsPersonnel_numRows = Math.min(rsPersonnel_numRows, rsPersonnel_total);
rsPersonnel_first = Math.min(rsPersonnel_first, rsPersonnel_total);
rsPersonnel_last = Math.min(rsPersonnel_last, rsPersonnel_total);
}
%>
<%
// *** Recordset Stats, Move To Record, and Go To Record: declare stats variables

// set the record count
var rsPersLoc_total = rsPersLoc.RecordCount;

// set the number of rows displayed on this page
if (rsPersLoc_numRows < 0) { // if repeat region set to all records
rsPersLoc_numRows = rsPersLoc_total;
} else if (rsPersLoc_numRows == 0) { // if no repeat regions
rsPersLoc_numRows = 1;
}

// set the first and last displayed record
var rsPersLoc_first = 1;
var rsPersLoc_last = rsPersLoc_first + rsPersLoc_numRows - 1;

// if we have the correct record count, check the other stats
if (rsPersLoc_total != -1) {
rsPersLoc_numRows = Math.min(rsPersLoc_numRows, rsPersLoc_total);
rsPersLoc_first = Math.min(rsPersLoc_first, rsPersLoc_total);
rsPersLoc_last = Math.min(rsPersLoc_last, rsPersLoc_total);
}
%>
<%
// *** Recordset Stats: if we don't know the record count, manually count them

if (rsPersonnel_total == -1) {

// count the total records by iterating through the recordset
for (rsPersonnel_total=0; !rsPersonnel.EOF; rsPersonnel.MoveNext()) {
rsPersonnel_total++;
}

// reset the cursor to the beginning
if (rsPersonnel.CursorType > 0) {
if (!rsPersonnel.BOF) rsPersonnel.MoveFirst();
} else {
rsPersonnel.Requery();
}

// set the number of rows displayed on this page
if (rsPersonnel_numRows < 0 || rsPersonnel_numRows > rsPersonnel_total) {
rsPersonnel_numRows = rsPersonnel_total;
}

// set the first and last displayed record
rsPersonnel_last = Math.min(rsPersonnel_first + rsPersonnel_numRows - 1, rsPersonnel_total);
rsPersonnel_first = Math.min(rsPersonnel_first, rsPersonnel_total);
}
%>
<%
// *** Recordset Stats: if we don't know the record count, manually count them

if (rsPersLoc_total == -1) {

// count the total records by iterating through the recordset
for (rsPersLoc_total=0; !rsPersLoc.EOF; rsPersLoc.MoveNext()) {
rsPersLoc_total++;
}

// reset the cursor to the beginning
if (rsPersLoc.CursorType > 0) {
if (!rsPersonnelDoc.BOF) rsPersLoc.MoveFirst();
} else {
rsPersLoc.Requery();
}

// set the number of rows displayed on this page
if (rsPersLoc_numRows < 0 || rsPersLoc_numRows > rsPersLoc_total) {
rsPersLoc_numRows = rsPersLoc_total;
}

// set the first and last displayed record
rsPersLoc_last = Math.min(rsPersLoc_first + rsPersLoc_numRows - 1, rsPersLoc_total);
rsPersLoc_first = Math.min(rsPersLoc_first, rsPersLoc_total);
}
%>
<% var MM_paramName = &quot;&quot;; %>
<%
// *** Move To Record and Go To Record: declare variables

var MM_rs = rsPersLoc;
var MM_rsCount = rsPersLoc_total;
var MM_size = rsPersLoc_numRows;
var MM_uniqueCol = &quot;&quot;;
MM_paramName = &quot;&quot;;
var MM_offset = 0;
var MM_atTotal = false;
var MM_paramIsDefined = (MM_paramName != &quot;&quot; && String(Request(MM_paramName)) != &quot;undefined&quot;);
%>
<%
// *** Move To Record: handle 'index' or 'offset' parameter

if (!MM_paramIsDefined && MM_rsCount != 0) {

// use index parameter if defined, otherwise use offset parameter
r = String(Request(&quot;index&quot;));
if (r == &quot;undefined&quot;) r = String(Request(&quot;offset&quot;));
if (r && r != &quot;undefined&quot;) MM_offset = parseInt(r);

// if we have a record count, check if we are past the end of the recordset
if (MM_rsCount != -1) {
if (MM_offset >= MM_rsCount || MM_offset == -1) { // past end or move last
if ((MM_rsCount % MM_size) != 0) { // last page not a full repeat region
MM_offset = MM_rsCount - (MM_rsCount % MM_size);
} else {
MM_offset = MM_rsCount - MM_size;
}
}
}

// move the cursor to the selected record
for (var i=0; !MM_rs.EOF && (i < MM_offset || MM_offset == -1); i++) {
MM_rs.MoveNext();
}
if (MM_rs.EOF) MM_offset = i; // set MM_offset to the last possible record
}
%>
<%
// *** Move To Record: if we dont know the record count, check the display range

if (MM_rsCount == -1) {

// walk to the end of the display range for this page
for (var i=MM_offset; !MM_rs.EOF && (MM_size < 0 || i < MM_offset + MM_size); i++) {
MM_rs.MoveNext();
}

// if we walked off the end of the recordset, set MM_rsCount and MM_size
if (MM_rs.EOF) {
MM_rsCount = i;
if (MM_size < 0 || MM_size > MM_rsCount) MM_size = MM_rsCount;
}

// if we walked off the end, set the offset based on page size
if (MM_rs.EOF && !MM_paramIsDefined) {
if ((MM_rsCount % MM_size) != 0) { // last page not a full repeat region
MM_offset = MM_rsCount - (MM_rsCount % MM_size);
} else {
MM_offset = MM_rsCount - MM_size;
}
}

// reset the cursor to the beginning
if (MM_rs.CursorType > 0) {
if (!MM_rs.BOF) MM_rs.MoveFirst();
} else {
MM_rs.Requery();
}

// move the cursor to the selected record
for (var i=0; !MM_rs.EOF && i < MM_offset; i++) {
MM_rs.MoveNext();
}
}
%>
<%
// *** Move To Record: update recordset stats

// set the first and last displayed record
rsPersLoc_first = MM_offset + 1;
rsPersLoc_last = MM_offset + MM_size;
if (MM_rsCount != -1) {
rsPersLoc_first = Math.min(rsPersLoc_first, MM_rsCount);
rsPersLoc_last = Math.min(rsPersLoc_last, MM_rsCount);
}

// set the boolean used by hide region to check if we are on the last record
MM_atTotal = (MM_rsCount != -1 && MM_offset + MM_size >= MM_rsCount);
%>
<%
// *** Go To Record and Move To Record: create strings for maintaining URL and Form parameters

// create the list of parameters which should not be maintained
var MM_removeList = &quot;&index=&quot;;
if (MM_paramName != &quot;&quot;) MM_removeList += &quot;&&quot; + MM_paramName.toLowerCase() + &quot;=&quot;;
var MM_keepURL=&quot;&quot;,MM_keepForm=&quot;&quot;,MM_keepBoth=&quot;&quot;,MM_keepNone=&quot;&quot;;

// add the URL parameters to the MM_keepURL string
for (var items=new Enumerator(Request.QueryString); !items.atEnd(); items.moveNext()) {
var nextItem = &quot;&&quot; + items.item().toLowerCase() + &quot;=&quot;;
if (MM_removeList.indexOf(nextItem) == -1) {
MM_keepURL += &quot;&&quot; + items.item() + &quot;=&quot; + Server.URLencode(Request.QueryString(items.item()));
}
}

// add the Form variables to the MM_keepForm string
for (var items=new Enumerator(Request.Form); !items.atEnd(); items.moveNext()) {
var nextItem = &quot;&&quot; + items.item().toLowerCase() + &quot;=&quot;;
if (MM_removeList.indexOf(nextItem) == -1) {
MM_keepForm += &quot;&&quot; + items.item() + &quot;=&quot; + Server.URLencode(Request.Form(items.item()));
}
}

// create the Form + URL string and remove the intial '&' from each of the strings
MM_keepBoth = MM_keepURL + MM_keepForm;
if (MM_keepBoth.length > 0) MM_keepBoth = MM_keepBoth.substring(1);
if (MM_keepURL.length > 0) MM_keepURL = MM_keepURL.substring(1);
if (MM_keepForm.length > 0) MM_keepForm = MM_keepForm.substring(1);
%>
<%
// *** Move To Record: set the strings for the first, last, next, and previous links

var MM_moveFirst=&quot;&quot;,MM_moveLast=&quot;&quot;,MM_moveNext=&quot;&quot;,MM_movePrev=&quot;&quot;;
var MM_keepMove = MM_keepBoth; // keep both Form and URL parameters for moves
var MM_moveParam = &quot;index&quot;;

// if the page has a repeated region, remove 'offset' from the maintained parameters
if (MM_size > 1) {
MM_moveParam = &quot;offset&quot;;
if (MM_keepMove.length > 0) {
params = MM_keepMove.split(&quot;&&quot;);
MM_keepMove = &quot;&quot;;
for (var i=0; i < params.length; i++) {
var nextItem = params.substring(0,params.indexOf(&quot;=&quot;));
if (nextItem.toLowerCase() != MM_moveParam) {
MM_keepMove += &quot;&&quot; + params;
}
}
if (MM_keepMove.length > 0) MM_keepMove = MM_keepMove.substring(1);
}
}

// set the strings for the move to links
if (MM_keepMove.length > 0) MM_keepMove += &quot;&&quot;;
var urlStr = Request.ServerVariables(&quot;URL&quot;) + &quot;?&quot; + MM_keepMove + MM_moveParam + &quot;=&quot;;
MM_moveFirst = urlStr + &quot;0&quot;;
MM_moveLast = urlStr + &quot;-1&quot;;
MM_moveNext = urlStr + (MM_offset + MM_size);
MM_movePrev = urlStr + Math.max(MM_offset - MM_size,0);
%>

I know it's a lot. It's behind a firewall and I am at wits end. The error says either BOF or EOF is true. So I need a current record. Is it just something I have to hand code because I know the records are there. I am sorry for all the bother lately.

If I could buy you guys a drink for always helping... I so would :)
thanks & much love!
Va.
 
Well to be honest, Its tough without more information. If you can post which line the errors on - and then point out the appropriate code, we can narrow it down.

Heres some reasons that I've been hit upside the head on.

-Joined fields (relationships) - I've either needed em, had the wrong type, or something.
-Wrong spelling
-Fields didn't Match
-Reserved names
-No Include line (or a dsn=?)

Check the usual suspects &quot;I like a man who grins when he fights.&quot;

-- Prime Minister Winston Churchill

Stuart
 
Either BOF or EOF is True, or the current record has been deleted. Requested Operation requires a current record.
/ASP/Personnel_tab1_blah blah.asp, line 317

pretty close except the blah blah. :)

Thanks Stuart... does anyone call you Stu.. or stew... just wondering.

thanks!
Va :P
 
lol can you post 5 lines or so both directions of line 317?


.... I get called much worse too [2thumbsup] &quot;I like a man who grins when he fights.&quot;

-- Prime Minister Winston Churchill

Stuart
 
<% while ((Repeat1__numRows-- != 0) && (!rsPersLoc.EOF)) { %>
<tr>
<td align=&quot;default&quot; width=&quot;11%&quot;>
<a href=&quot;personnel_tab1.asp?<%= MM_keepBoth + ((MM_keepBoth!=&quot;&quot;)?&quot;&&quot;:&quot;&quot;) + &quot;PersID=&quot; + rsPersLoc.Fields.Item(&quot;PersID&quot;).Value %>&quot;><%=(rsPersLoc.Fields.Item(&quot;PersID&quot;).Value)%></a> </td>
<td align=&quot;default&quot; width=&quot;11%&quot;>
<%=(rsPersLoc.Fields.Item(&quot;LName&quot;).Value)%> </td>
<td align=&quot;default&quot; width=&quot;11%&quot;>
<%=(rsPersLoc.Fields.Item(&quot;FName&quot;).Value)%> </td>
<td align=&quot;default&quot; width=&quot;11%&quot;>
<%=(rsPersLoc.Fields.Item(&quot;MI&quot;).Value)%> </td>
<td align=&quot;default&quot; width=&quot;11%&quot;>
<%=(rsPersLoc.Fields.Item(&quot;Title&quot;).Value)%> </td>
<td align=&quot;default&quot; width=&quot;11%&quot;>
<%=(rsPersLoc.Fields.Item(&quot;PhoneDSN&quot;).Value)%> </td>
<td align=&quot;default&quot; width=&quot;11%&quot;>
<%=(rsPersLoc.Fields.Item(&quot;PhoneComm&quot;).Value)%> </td>
<td align=&quot;default&quot; width=&quot;11%&quot;>
<%=(rsPersLoc.Fields.Item(&quot;PhoneExt&quot;).Value)%> </td>
<td align=&quot;default&quot; width=&quot;11%&quot;>
<%=(rsPersLoc.Fields.Item(&quot;Email&quot;).Value)%> </td>
</tr>
<%
Repeat1__index++;
rsPersLoc.MoveNext();
}
%>

I guess posting all of the code is kind of annoying. Especially now that I have to scroll past it... So Mr. Chase, I finally got one record to show but can't switch records. I dunno, did I happen to mention how illogical I am. Tell me how to get there and I'll never forget, send me without a map and I will be wandering for years. I am stopping to ask for directions however.. hee hee
My error now shows for line 363 but says the same thing. Before banging your own head, I am going to try populating more of the database to make sure every option is met. Shouldn't there be a way to allow a null value so it doesn't error out though? I dunno.

I will be back to see if you have found something simple in my logic and are laughing at me. Of course, I wouldn't be able to hear you so you would have to tell me.

I won't call you anything bad. You're too nice to me for that! Plus, you have to read all of my rambling just to help me.

THANKS!!! -Va.
 
I don't see anything wrong with the code per say. However you really should consider using a naming convention.

I don't see any reserved fields but as my good buddy MLawson will accuse me of (with a shaking finger) It's easy to set up - easy to maintain, and a boat load of problems if you dont.

for example.
In my access database - the database starts with db like dbAdvertising.

My tables inside access start with tbl
my queries inside access start with qry
my fields inside either start with fld

on html side of things
my text input box's and stuff all start with txt
my Dim's I start with str
my session variables I start with sv

etc.

Might seem like alot - and it can be a bit to get used to it - but if your handcoding, it's actually easier - and less chance you'll mix up fields. - Which saves you....... debuging time.

Anyhew, make a query in Access - pulling all of the fields over whichever table that is pulling from - do your joins there - test to make sure all is going good.

Then base your recordset off of the query table in Access. You can also filter by ID there.

Queries seem to handle null values better - I confess to not know why - but some of these other guys do.



&quot;I like a man who grins when he fights.&quot;

-- Prime Minister Winston Churchill

Stuart
 
Status
Not open for further replies.

Part and Inventory Search

Sponsor

Back
Top