Smart questions
Smart answers
Smart people
INTELLIGENT WORK FORUMS
FOR COMPUTER PROFESSIONALS

Member Login

Come Join Us!

Are you a
Computer / IT professional?
Join Tek-Tips now!
  • Talk With Other Members
  • Be Notified Of Responses
    To Your Posts
  • Keyword Search
  • One-Click Access To Your
    Favorite Forums
  • Automated Signatures
    On Your Posts
  • Best Of All, It's Free!

Join Tek-Tips
*Tek-Tips's functionality depends on members receiving e-mail. By joining you are opting in to receive e-mail.

LINK TO THIS FORUM!

Add Stickiness To Your Site By Linking To This Professionally Managed Technical Forum.
Just copy and paste the
code below into your site.

Partner With Us!

"Best Of Breed" Forums Add Stickiness To Your Site
Partner Button
(Download This Button Today!)

Feedback

"...I just wanted to say THANKS for the forum. The knowledge I gain from your site is invaluable..."

Geography

Where in the world do Tek-Tips members come from?

better way to list all of these options?

dkemas (Programmer)
26 Apr 12 9:37
I have made two functions to insert and update data to a database from a rather large form. My code below works fine, but I was wondering whether it was possible to make it much simpler through iteration or similar?

Here's my functions

CODE

function insertCF($id,$cf1_score,$cf1_isseen,$sc1_cf_id,$cf1_pdp,$cf1_redflag,$cf2_score,$cf2_isseen,$sc2_cf_id,$cf2pdp,$cf2_redflag,$cf3_score,$cf3_isseen,$sc3_cf_id,$cf3_pdp,$cf3_redflag,$cf4_score,$cf4_isseen,$sc4_cf_id,$cf4_pdp,$cf4_redflag,$cf5_score,$cf5_isseen,$sc5_cf_id,$cf5_pdp,$cf5_redflag,$cf6_score,$cf6_isseen,$sc6_cf_id,$cf6_pdp,$cf6_redflag,$cf7_score,$cf7_isseen,$sc7_cf_id,$cf7_pdp,$cf7_redflag,$cf8_score,$cf8_isseen,$sc8_cf_id,$cf8_pdp,$cf8_redflag,$cf9_score,$cf9_isseen,$sc9_cf_id,$cf9_pdp,$cf9_redflag,$cf10_score,$cf10_isseen,$sc10_cf_id,$cf10_pdp,$cf10_redflag,$cf11_score,$cf11_isseen,$sc11_cf_id,$cf11_pdp,$cf11_redflag,$cf12_score,$cf12_isseen,$sc12_cf_id,$cf12pdp,$cf12_redflag,$cf13_score,$cf13_isseen,$sc13_cf_id,$cf13_pdp,$cf13_redflag,$cf14_score,$cf14_isseen,$sc14_cf_id,$cf14_pdp,$cf14_redflag,$cf15_score,$cf15_isseen,$sc15_cf_id,$cf15_pdp,$cf15_redflag,$cf16_score,$cf16_isseen,$sc16_cf_id,$cf16_pdp,$cf16_redflag,$cf17_score,$cf17_isseen,$sc17_cf_id,$cf17_pdp,$cf17_redflag,$cf18_score,$cf18_isseen,$sc18_cf_id,$cf18_pdp,$cf18_redflag,$cf19_score,$cf19_isseen,$sc19_cf_id,$cf19_pdp,$cf19_redflag,$cf20_score,$cf20_isseen,$sc20_cf_id,$cf20_pdp,$cf20_redflag,$cfcomments,$redflagnotify)
    {
        $result = $this->Query("insert into mytable values ('','$cf1_score','$cf1_isseen','$sc1_cf_id','$cf1_pdp','$cf1_redflag','$cf2_score','$cf2_isseen','$sc2_cf_id','$cf2_pdp','$cf2_redflag','$cf3_score','$cf3_isseen','$sc3_cf_id','$cf3_pdp','$cf3_redflag','$cf4_score','$cf4_isseen','$sc4_cf_id','$cf4_pdp','$cf4_redflag','$cf5_score','$cf5_isseen','$sc5_cf_id','$cf5_pdp','$cf5_redflag','$cf6_score','$cf6_isseen','$sc6_cf_id','$cf6_pdp','$cf6_redflag','$cf7_score','$cf7_isseen','$sc7_cf_id','$cf7_pdp','$cf7_redflag','$cf8_score','$cf8_isseen','$sc8_cf_id','$cf8_pdp','$cf8_redflag','$cf9_score','$cf9_isseen','$sc9_cf_id','$cf9_pdp','$cf9_redflag','$cf10_score','$cf10_isseen','$sc10_cf_id','$cf10_pdp','$cf10_redflag','$cf11_score','$cf11_isseen','$sc11_cf_id','$cf11_pdp','$cf11_redflag','$cf12_score','$cf12_isseen','$sc12_cf_id','$cf12_pdp','$cf12_redflag','$cf13_score','$cf13_isseen','$sc13_cf_id','$cf13_pdp','$cf13_redflag','$cf14_score','$cf14_isseen','$sc14_cf_id','$cf14_pdp','$cf14_redflag','$cf15_score','$cf15_isseen','$sc15_cf_id','$cf15_pdp','$cf15_redflag','$cf16_score','$cf16_isseen','$sc16_cf_id','$cf16_pdp','$cf16_redflag','$cf17_score','$cf17_isseen','$sc17_cf_id','$cf17_pdp','$cf17_redflag','$cf18_score','$cf18_isseen','$sc18_cf_id','$cf18_pdp','$cf18_redflag','$cf19_score','$cf19_isseen','$sc19_cf_id','$cf19_pdp','$cf19_redflag','$cf20_score','$cf20_isseen','$sc20_cf_id','$cf20_pdp','$cf20_redflag','$cfcomments','$redflagnotify')");
    }
    
    function updateCF($cf1_score,$cf1_isseen,$sc1_cf_id,$cf1_pdp,$cf1_redflag,$cf2_score,$cf2_isseen,$sc2_cf_id,$cf2_pdp,$cf2_redflag,$cf3_score,$cf3_isseen,$sc3_cf_id,$cf3_pdp,$cf3_redflag,$cf4_score,$cf4_isseen,$sc4_cf_id,$cf4_pdp,$cf4_redflag,$cf5_score,$cf5_isseen,$sc5_cf_id,$cf5_pdp,$cf5_redflag,$cf6_score,$cf6_isseen,$sc6_cf_id,$cf6_pdp,$cf6_redflag,$cf7_score,$cf7_isseen,$sc7_cf_id,$cf7_pdp,$cf7_redflag,$cf8_score,$cf8_isseen,$sc8_cf_id,$cf8_pdp,$cf8_redflag,$cf9_score,$cf9_isseen,$sc9_cf_id,$cf9_pdp,$cf9_redflag,$cf10_score,$cf10_isseen,$sc10_cf_id,$cf10_pdp,$cf10_redflag,$cf11_score,$cf11_isseen,$sc11_cf_id,$cf11_pdp,$cf11_redflag,$cf12_score,$cf12_isseen,$sc12_cf_id,$cf12_pdp,$cf12_redflag,$cf13_score,$cf13_isseen,$sc13_cf_id,$cf13_pdp,$cf13_redflag,$cf14_score,$cf14_isseen,$sc14_cf_id,$cf14_pdp,$cf14_redflag,$cf15_score,$cf15_isseen,$sc15_cf_id,$cf15_pdp,$cf15_redflag,$cf16_score,$cf16_isseen,$sc16_cf_id,$cf16_pdp,$cf16_redflag,$cf17_score,$cf17_isseen,$sc17_cf_id,$cf17_pdp,$cf17_redflag,$cf18_score,$cf18_isseen,$sc18_cf_id,$cf18_pdp,$cf18_redflag,$cf19_score,$cf19_isseen,$sc19_cf_id,$cf19_pdp,$cf19_redflag,$cf20_score,$cf20_isseen,$sc20_cf_id,$cf20_pdp,$cf20_redflag,$cfcomments,$redflagnotify,$id,)
    {
        $result = $this->Query("update mytable set
        cf1_score='$cf1_score',
        cf1_isseen='$cf1_isseen',
        sc1_cf_id='$sc1_cf_id',
        cf1_pdp='$cf1_pdp',
        cf1_redflag='$cf1_redflag',
        cf2_score='$cf2_score',
        cf2_isseen='$cf2_isseen',
        sc2_cf_id='$sc2_cf_id',
        cf2_pdp='$cf2_pdp',
        cf2_redflag='$cf2_redflag',
        cf3_score='$cf3_score',
        cf3_isseen='$cf3_isseen',
        sc3_cf_id='$sc3_cf_id',
        cf3_pdp='$cf3_pdp',
        cf3_redflag='$cf3_redflag',
        cf4_score='$cf4_score',
        cf4_isseen='$cf4_isseen',
        sc4_cf_id='$sc4_cf_id',
        cf4_pdp='$cf4_pdp',
        cf4_redflag='$cf4_redflag',
        cf5_score='$cf5_score',
        cf5_isseen='$cf5_isseen',
        sc5_cf_id='$sc5_cf_id',
        cf5_pdp='$cf5_pdp',
        cf5_redflag='$cf5_redflag',
        cf6_score='$cf6_score',
        cf6_isseen='$cf6_isseen',
        sc6_cf_id='$sc6_cf_id',
        cf6_pdp='$cf6_pdp',
        cf6_redflag='$cf6_redflag',
        cf7_score='$cf7_score',
        cf7_isseen='$cf7_isseen',
        sc7_cf_id='$sc7_cf_id',
        cf7_pdp='$cf7_pdp',
        cf7_redflag='$cf7_redflag',
        cf8_score='$cf8_score',
        cf8_isseen='$cf8_isseen',
        sc8_cf_id='$sc8_cf_id',
        cf8_pdp='$cf8_pdp',
        cf8_redflag='$cf8_redflag',
        cf9_score='$cf9_score',
        cf9_isseen='$cf9_isseen',
        sc9_cf_id='$sc9_cf_id',
        cf9_pdp='$cf9_pdp',
        cf9_redflag='$cf9_redflag',
        cf10_score='$cf10_score',
        cf10_isseen='$cf10_isseen',
        sc10_cf_id='$sc10_cf_id',
        cf10_pdp='$cf10_pdp',
        cf10_redflag='$cf10_redflag',
        cf11_score='$cf11_score',
        cf11_isseen='$cf11_isseen',
        sc11_cf_id='$sc11_cf_id',
        cf11_pdp='$cf11_pdp',
        cf11_redflag='$cf11_redflag',
        cf12_score='$cf12_score',
        cf12_isseen='$cf12_isseen',
        sc12_cf_id='$sc12_cf_id',
        cf12_pdp='$cf12_pdp',
        cf12_redflag='$cf12_redflag',
        cf13_score='$cf13_score',
        cf13_isseen='$cf13_isseen',
        sc13_cf_id='$sc13_cf_id',
        cf13_pdp='$cf13_pdp',
        cf13_redflag='$cf13_redflag',
        cf14_score='$cf14_score',
        cf14_isseen='$cf14_isseen',
        sc14_cf_id='$sc14_cf_id',
        cf14_pdp='$cf14_pdp',
        cf14_redflag='$cf14_redflag',
        cf15_score='$cf15_score',
        cf15_isseen='$cf15_isseen',
        sc15_cf_id='$sc15_cf_id',
        cf15_pdp='$cf15_pdp',
        cf15_redflag='$cf15_redflag',
        cf16_score='$cf16_score',
        cf16_isseen='$cf16_isseen',
        sc16_cf_id='$sc16_cf_id',
        cf16_pdp='$cf16_pdp',
        cf16_redflag='$cf16_redflag',
        cf17_score='$cf17_score',
        cf17_isseen='$cf17_isseen',
        sc17_cf_id='$sc17_cf_id',
        cf17_pdp='$cf17_pdp',
        cf17_redflag='$cf17_redflag',
        cf18_score='$cf18_score',
        cf18_isseen='$cf18_isseen',
        sc18_cf_id='$sc18_cf_id',
        cf18_pdp='$cf18_pdp',
        cf18_redflag='$cf18_redflag',
        cf19_score='$cf19_score',
        cf19_isseen='$cf19_isseen',
        sc19_cf_id='$sc19_cf_id',
        cf19_pdp='$cf19_pdp',
        cf19_redflag='$cf19_redflag',
        cf20_score='$cf20_score',
        cf20_isseen='$cf20_isseen',
        sc20_cf_id='$sc20_cf_id',
        cf20_pdp='$cf20_pdp',
        cf20_redflag='$cf20_redflag',
        cfcomments='$cfcomments',
        redflagnotify='$redflagnotify'
        where id='$id'");

which are called with

CODE

$result = $dbStuff->insertCF('',$_POST['1score'],$_POST['1isseen'],$_POST['1scenario'],$_POST['1pdp'],$_POST['1redflag'],$_POST['2score'],$_POST['2isseen'],$_POST['2scenario'],$_POST['2pdp'],$_POST['2redflag'],$_POST['3score'],$_POST['3isseen'],$_POST['3scenario'],$_POST['3pdp'],$_POST['3redflag'],$_POST['4score'],$_POST['4isseen'],$_POST['4scenario'],$_POST['4pdp'],$_POST['4redflag'],$_POST['5score'],$_POST['5isseen'],$_POST['5scenario'],$_POST['5pdp'],$_POST['5redflag'],$_POST['6score'],$_POST['6isseen'],$_POST['6scenario'],$_POST['6pdp'],$_POST['6redflag'],$_POST['7score'],$_POST['7isseen'],$_POST['7scenario'],$_POST['7pdp'],$_POST['7redflag'],$_POST['8score'],$_POST['8isseen'],$_POST['8scenario'],$_POST['8pdp'],$_POST['8redflag'],$_POST['9score'],$_POST['9isseen'],$_POST['9scenario'],$_POST['9pdp'],$_POST['9redflag'],$_POST['10score'],$_POST['10isseen'],$_POST['10scenario'],$_POST['10pdp'],$_POST['10redflag'],$_POST['11score'],$_POST['11isseen'],$_POST['11scenario'],$_POST['11pdp'],$_POST['11redflag'],$_POST['12score'],$_POST['12isseen'],$_POST['12scenario'],$_POST['12pdp'],$_POST['12redflag'],$_POST['13score'],$_POST['13isseen'],$_POST['13scenario'],$_POST['13pdp'],$_POST['13redflag'],$_POST['14score'],$_POST['14isseen'],$_POST['14scenario'],$_POST['14pdp'],$_POST['14redflag'],$_POST['15score'],$_POST['15isseen'],$_POST['15scenario'],$_POST['15pdp'],$_POST['15redflag'],$_POST['16score'],$_POST['16isseen'],$_POST['16scenario'],$_POST['16pdp'],$_POST['16redflag'],$_POST['17score'],$_POST['17isseen'],$_POST['17scenario'],$_POST['17pdp'],$_POST['17redflag'],$_POST['18score'],$_POST['18isseen'],$_POST['18scenario'],$_POST['18pdp'],$_POST['18redflag'],$_POST['19score'],$_POST['19isseen'],$_POST['19scenario'],$_POST['19pdp'],$_POST['19redflag'],$_POST['20score'],$_POST['20isseen'],$_POST['20scenario'],$_POST['20pdp'],$_POST['20redflag'],$_POST['comments'],$_POST['redflagnotify']);

$result = $dbStuff->updateCF($_POST['1score'], $_POST['1isseen'], $_POST['1scenario'], $_POST['1pdp'], $_POST['1redflag'],$_POST['2score'], $_POST['2isseen'], $_POST['2scenario'], $_POST['2pdp'], $_POST['2redflag'],$_POST['3score'], $_POST['3isseen'], $_POST['3scenario'], $_POST['3pdp'], $_POST['3redflag'],$_POST['4score'], $_POST['4isseen'], $_POST['4scenario'], $_POST['4pdp'], $_POST['4redflag'],$_POST['5score'], $_POST['5isseen'], $_POST['5scenario'], $_POST['5pdp'], $_POST['5redflag'],$_POST['6score'], $_POST['6isseen'], $_POST['6scenario'], $_POST['6pdp'], $_POST['6redflag'],$_POST['7score'], $_POST['7isseen'], $_POST['7scenario'], $_POST['7pdp'], $_POST['7redflag'],$_POST['8score'], $_POST['8isseen'], $_POST['8scenario'], $_POST['8pdp'], $_POST['8redflag'],$_POST['9score'], $_POST['9isseen'], $_POST['9scenario'], $_POST['9pdp'], $_POST['9redflag'],$_POST['10score'], $_POST['10isseen'], $_POST['10scenario'], $_POST['10pdp'], $_POST['10redflag'], $_POST['11score'], $_POST['11isseen'], $_POST['11scenario'], $_POST['11pdp'], $_POST['11redflag'],$_POST['12score'], $_POST['12isseen'], $_POST['12scenario'], $_POST['12pdp'], $_POST['12redflag'],$_POST['13score'], $_POST['13isseen'], $_POST['13scenario'], $_POST['13pdp'], $_POST['13redflag'],$_POST['14score'], $_POST['14isseen'], $_POST['14scenario'], $_POST['14pdp'], $_POST['14redflag'],$_POST['15score'], $_POST['15isseen'], $_POST['15scenario'], $_POST['15pdp'], $_POST['15redflag'],$_POST['16score'], $_POST['16isseen'], $_POST['16scenario'], $_POST['16pdp'], $_POST['16redflag'],$_POST['17score'], $_POST['17isseen'], $_POST['17scenario'], $_POST['17pdp'], $_POST['17redflag'],$_POST['18score'], $_POST['18isseen'], $_POST['18scenario'], $_POST['18pdp'], $_POST['18redflag'],$_POST['19score'], $_POST['19isseen'], $_POST['19scenario'], $_POST['19pdp'], $_POST['19redflag'],$_POST['20score'], $_POST['20isseen'], $_POST['20scenario'], $_POST['20pdp'], $_POST['20redflag'], $_POST['comments'],$_POST['redflagnotify'],$_POST['id']);
jpadie (TechnicalUser)
26 Apr 12 9:41
yup.  there's a much easier way.  check back in ten minutes and i'll post it.
 
feherke (Programmer)
26 Apr 12 10:15
Hi

Personally I would prefer something like this :

CODE --> PHP

<?php
// generic preprocessing
$data=array();
for ($i=1;$i<=20;$i++) {
  $data["cf${i}_score"]=$_POST["${i}score"];
  $data["cf${i}_isseen"]=$_POST["${i}isseen"];
  $data["sc${i}_cf_id"]=$_POST["${i}scenario"];
  $data["cf${i}_pdp"]=$_POST["${i}pdp"];
  $data["cf${i}_redflag"]=$_POST["${i}redflag"];
}
$data['cfcomments']=$_POST['comments'];
$data['redflagnotify']=$_POST['redflagnotify'];

// escaping
foreach ($data as $field=>$value)
  $data[$field]="'".mysql_real_escape_string($value)."'";

// insert
$result = $this->Query("insert into mytable values ('',".implode(',',array_values($data)).')');

// update
$pair=array();
foreach ($data as $field=>$value)
  $pair[]="$field=$value";

$result = $this->Query('update mytable set '.implode(',',$pair)." where id='".mysql_real_escape_string($_POST['id'])."'");
Warning The above code was not tested

Feherke.
http://feherke.github.com/

jpadie (TechnicalUser)
26 Apr 12 10:20
this is the code

note that the base class is generic.  you can easily add in other methods to it and reuse it across other objects.

CODE


<?php
class base {
    
    public function __construct(){
        foreach($this->fields as $field):
            if(!isset($this->{$field})) $this->{$field} = NULL;
        endforeach;
    }
    
    public function getPrimary(){
        return !empty($this->{$this->primary}) ? $this->{$this->primary} : false;
    }
    
    public function save(){
        if ($this->getPrimary() === false):
            $return = $this->insert();
        else:
            $return = $this->update();
        endif;
        return $return;
        
    }
    
    public function insert(){
        global $dbObj;
        $params = array();
        $sql = "INSERT into {$this->table} SET ";
        foreach($this->fields as $key=>$field):
            $fields[] = "`$field` = '%s'";
            $params[] = is_array($this->{$field}) ? mysql_real_escape_string(serialize($this->{$field})) : mysql_real_escape_string($this->{$field});
        endforeach;
        $query = $sql . implode(',', $fields);
        mysql_last_insert_id();
        
        return $dbObj->query(vsprintf($query, $params));
        /* alternative code
        mysql_query(vsprintf($query, $params)) or die(mysql_error());
        return mysql_insert_id();
        */
    }
    
    public function update(){
        global $dbObj;
        $params = array();
        $sql = "UPDATE {$this->table} SET ";
        foreach($this->fields as $key=>$field):
            if($field === $this->primary) continue;
            $fields[] = "`$field` = '%s'";
            $params[] = is_array($this->{$field}) ? mysql_real_escape_string(serialize($this->{$field})) : mysql_real_escape_string ($this->{$field});
        endforeach;
        $query = $sql . implode(',', $fields) . " WHERE {$this->primary} = '%s'";
        $params[] = $this->getPrimary();
        return $dbObj->Query(vsprintf($query, $params));
        /* alternative code
        mysql_query(vsprintf($query, $params)) or die (mysql_error());
        return mysql_affected_rows();
        */
    }
    
    public function load($row){
        if(is_array($row)) $row = (object) $row;
        foreach ($this->fields as $field):
            if(isset($row->{$field})):
                $this->{$field} = $this->is_serialized($row->{$field}) ? unserialize($row->{$field}) : trim($row->{$field});
            else:
                $this->{$field} = null;
            endif;
        endforeach;
    }
    
    private function isSerialized($string){
        return (@unserialize($string) !== FALSE);
    }
}

class cf extends base {
    public $fields = array('id','cfcomments','redflagnotify' );
    public $primary = 'id';
    public $table = 'mytable';
    
    public function __construct(){
        $a = array('score', 'isseen', 'cf_id', 'pdp', 'redflag');
        for($i=1; $i<=20; $i++):
            foreach($a as $item):
                $this->fields[] = 'cf' . $i .'_' . $item;
            endforeach;
        endfor;
        parent::__construct();
    }
}
?>
 
        

use it like this

CODE


//to insert OR update
$cf = new CF;
$cf->load($_POST); //this is safe because the object will only take on board its own fields
$result = $cf->save(); //the code determines whether to update or insert
 
        

note that this assumes you have a database class handling the querying and that the dbclass object is called $dbObj.  the above can be easily rewritten to avoid this.  the alternative code is in the base class already, just commented out.

Note also that this performs no checks on your values to ensure that they are valid before database insertion.

and  ... having that many repetitive columns is suggestive of poor database normalisation.

and lastly ... the cf class could easily be extended to provide a nice loop to create the html forms for you on the fly.
 

Reply To This Thread

Posting in the Tek-Tips forums is a member-only feature.

Click Here to join Tek-Tips and talk with other members!

Back To Forum

Close Box

Join Tek-Tips® Today!

Join your peers on the Internet's largest technical computer professional community.
It's easy to join and it's free.

Here's Why Members Love Tek-Tips Forums:

Register now while it's still free!

Already a member? Close this window and log in.

Join Us             Close